search

cfpb / hmda-pilot

Creative Commons Zero v1.0 Universal
6 stars 8 forks source link

Grunt in container #420

Closed wpears closed 9 years ago

wpears commented 9 years ago

The grunt build now runs when building the container, meaning running containers is very light, won't differ across differs slaves, and, most importantly, doesn't require node and build tools for jenkins.

A casualty of this PR is the imagemin task, which alpine refused to build the native dependencies of, even given much urging. I was going to copy over the source images with the minified ones and check them in, but the savings for all affected images only totals ~7kb. So probably not worth the maintenance/slightly reduced quality at this juncture.

hkeeler commented 9 years ago

All reviewed up. Looks good overall. Just the one thing.

awolfe76 commented 9 years ago

:+1: I like this way of handling it.

Something like https://www.npmjs.com/package/load-grunt-config might help that Gruntfile too. :wink:

wpears commented 9 years ago

Should be good to go now; pretty funny bug that would make tests fail in October only.

hkeeler commented 9 years ago

Looks good. Merging...