search

cfpb / hmda-platform

The HMDA Submission backend applications.
Creative Commons Zero v1.0 Universal
103 stars 94 forks source link

Leap year exception in data publisher #4746

Closed rkovalik-raft closed 6 months ago

rkovalik-raft commented 8 months ago

The unit tests for 2021 quarters in QuarterTimeBarrierTest are failing and need to be fixed.

rkovalik-raft commented 7 months ago

This is failing for the year 2023 as well. From prod logs:

[2024-01-19 03:30:00,001][ERROR][hmda-data-publisher-akka.actor.default-dispatcher-202] Invalid date 'DayOfYear 366' as '2023' is not a leap year
java.time.DateTimeException: Invalid date 'DayOfYear 366' as '2023' is not a leap year
    at java.base/java.time.LocalDate.ofYearDay(LocalDate.java:296)
    at hmda.publisher.helper.QuarterTimeBarrier$.getEndDateForQuarter(QuarterTimeBarrier.scala:93)
    at hmda.publisher.helper.QuarterTimeBarrier.runIfStillRelevant(QuarterTimeBarrier.scala:34)
    at hmda.publisher.scheduler.LarScheduler$$anonfun$receive$1.$anonfun$applyOrElse$5(LarScheduler.scala:147)
    at scala.collection.immutable.List.foreach(List.scala:431)
    at hmda.publisher.scheduler.LarScheduler$$anonfun$receive$1.applyOrElse(LarScheduler.scala:144)