cfpb / idea-box

An application that lets an organization collect ideas, comment on them, and vote them up.

Creative Commons Zero v1.0 Universal

159 stars 49 forks source link

Fix pagination when browsing tags #94

Closed m3brown closed 9 years ago

m3brown commented 9 years ago

Currently, if you're browsing a page with tags (e.g. /idea/list/?tags=tagname), if there are enough records for there to be pagination at the bottom, the pagination links remove the tags from the context (e.g. /idea/list/?page_num=2).

This update checks to see if the current context has any tags, and appends them to the pagination urls if appropriate.

marcesher commented 9 years ago

@m3brown I'd like to merge this, but the travis failure concerns me. Problem is, it's not related to your change but to some other, bigger problem. Any ideas?

cmc333333 commented 9 years ago

89 would solve :grinning:

as would something simpler, a la https://github.com/cfpb/regulations-core/commit/e0a8bd18b96bcf69902dc0ab1e9f49e1c4565e57

m3brown commented 9 years ago

I'm in the final stages of testing #89 right now, and will rebase this PR shortly.

m3brown commented 9 years ago

It's passing now, @marcesher

marcesher commented 9 years ago

looks good to me. Thanks @m3brown and @cmc333333 !