search

cfpb / idea-box

An application that lets an organization collect ideas, comment on them, and vote them up.
Creative Commons Zero v1.0 Universal
159 stars 49 forks source link

Pin a bunch of requirements; use core.taggit by default #98

Closed Scotchester closed 7 years ago

Scotchester commented 7 years ago

Newer versions are not compatible with this project.

See https://github.com/cfpb/idea-box/issues/97#issuecomment-308565741 and https://github.com/cfpb/idea-box/issues/95#issuecomment-175143283

@m3brown Any reason you know of that this would be a bad idea?

Scotchester commented 7 years ago

I have no idea what to do about the build failures. It ran fine on my machine with Python 2.7.10. @richaagarwal, would you be able to take a look?

Scotchester commented 7 years ago

Updated to use core.taggit by default, as well. See https://github.com/cfpb/idea-box/issues/97#issuecomment-308568617

Scotchester commented 7 years ago

Managed to get the tests passing by walking back various dependencies to their last known working versions! I'll give @richaagarwal a little time to review before merging.

richaagarwal commented 7 years ago

@Scotchester Reviewing now!

richaagarwal commented 7 years ago

Oh, just realized we're in an app I've never used. I'm not familiar with this but pinning requirements seems fine? If you'd like me to test it locally etc. I'll need a little more time to get that all set up.

Scotchester commented 7 years ago

If you want to give it a try, the instructions in the README are fairly straightforward, but I'm comfortable meeting with just your looking over it, if you are.

richaagarwal commented 7 years ago

Yeah, feel free to merge ;)