Added is_whole boolean for is_number checks

cfpb / regtech-data-validator

Data validation tool for CFPB's RegTech systems

Creative Commons Zero v1.0 Universal

1 stars 0 forks source link

Added is_whole boolean for is_number checks #221

Closed jcadam14 closed 4 months ago

jcadam14 commented 4 months ago

Closes #220

github-actions[bot] commented 4 months ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
src/regtech_data_validator
check_functions.py
Project Total

This report was generated by python-coverage-comment-action

jcadam14 commented 4 months ago

LGTM. All the tests still pass. 😄 My only concern was just that I may have missed some edge case the previous logic was handling.

Not using the pytests, I tested with several sblars I've generated with various values for fields using this check and they all worked as expected. So functional tests gave me the piece of mind I needed for this ;)

hkeeler commented 4 months ago

I knew you would. 😉 ...and thank you for doing so. 😄 I also tested a fair bit locally, but just at the function level. Nothing like using real files.