Too many things, sorry - Githubissues

cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information

Other

28 stars 43 forks source link

Too many things, sorry #507

Closed theresaanna closed 10 years ago

theresaanna commented 10 years ago

I'll annotate throughout, calling people out so that you can zero in on what you probably care about.

Includes:

remove Dispatch.js
add definition loading spinner
ajax load diffs and search results
changing page title format

cmc333333 commented 10 years ago

Pointed out a few things which might be better (mostly just wording) but nothing that should prevent the pull request from going through if they are painful. :+1: from me

theresaanna commented 10 years ago

@cmc333333 Did you have any comments on the JS?

cmc333333 commented 10 years ago

@theresaanna : Wrote some of my thoughts as I skimmed through the code. With the exception of the permalinks, nothing important -- just ideas.

khandelwal commented 10 years ago

Akin to George, I am slaying this monster.