cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

Grunt updates #682

Closed ascott1 closed 9 years ago

ascott1 commented 9 years ago

This should make working with the front-end more nicerer.

Additions

KimberlyMunoz commented 9 years ago

:+1: :+1:

I had some concerns about excluding the css map, but the site works great without it and this definitely makes working on the front-end more pleasant. The only thing is that when I run grunt build now, there's a few files that change from the current version, which seems odd if our gruntfiles are the same.

image

ascott1 commented 9 years ago

Hmm, it's possible that we have slightly different dependencies locally, since some of them are not pinned to an exact version number. I'll do some digging...

ascott1 commented 9 years ago

Oh, and once we have a proper build script on the server we should remove these built files from source control.

ascott1 commented 9 years ago

Looks like this is related to sourcemaps on the JS files in development mode... I'm not sure that there's a fix until we stop checking these in, but I'm open to any ideas.

screen shot 2015-03-02 at 10 53 46 am

ascott1 commented 9 years ago

Thanks @KimberlyMunoz!