search

cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

set up eslint #684

Closed ascott1 closed 9 years ago

ascott1 commented 9 years ago

This sets up ESLint in place of JSHint and adds the appropriate grunt task. I've disabled all of the current failures (since they were passing the JSHint file), but it may be worth going through and systematically fixing many of them or consciously choosing to ignore the suggestion.

Note: Let's wait to merge until after the front end team discusses the us of ESLint this afternoon.

ascott1 commented 9 years ago

Before merging, it may be worth ripping out all of the custom JSHint comments throughout the code as well.

ascott1 commented 9 years ago

I think this should be merge ready now!

KimberlyMunoz commented 9 years ago

Looks good, I'm going to run it to test before merging.

ascott1 commented 9 years ago

Sounds like a plan!

Relatedly, I opened up this issue to create a standardized ESLint file across projects. Once we've reached a consensus, we can make sure out stuff conforms.