JS models unit tests - Githubissues

cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information

Other

28 stars 43 forks source link

Closed ascott1 closed 9 years ago

ascott1 commented 9 years ago

This adds unit tests to the application's models. @KimberlyMunoz and I worked closely on setting these.

Tests for each of the models (with the exception of reg-model)
Changes
Bumps the node dependency to 0.12.0
Moves the definition model to its own module (it was in the initialize method of one of the views)
Review
@KimberlyMunoz
Preview

screen shot 2015-03-26 at 4 55 04 pm

ascott1 commented 9 years ago

Updated to reflect @KimberlyMunoz's comments. Good catches!

KimberlyMunoz commented 9 years ago

Oops. Need a quick conflict fix.

ascott1 commented 9 years ago

Merge conflict should be fixed!

contolini commented 9 years ago

So. much. green. :dollar: :moneybag: :dollar: :moneybag: :dollar: :moneybag:

imuchnik commented 9 years ago

@ascott1 Tests with no asserts are unethical :no_good:

ascott1 commented 9 years ago

@ascott1 Tests with no asserts are unethical

And sometimes completely accidental :stuck_out_tongue_winking_eye: