search

cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

fix IE url bugs #705

Closed ascott1 closed 9 years ago

ascott1 commented 9 years ago

This should fix the bug where URL hashes weren't being appended correctly. To be totally honest I don't love the way I did this, so I'm open to feedback and criticsm @KimberlyMunoz.

I would also appreciate a thorough manual testing before merging.

Also, I'm not sure if this would effect multiple page search results and I can't test locally.

ascott1 commented 9 years ago

This might solve an issue we don't need to solve. Hold off on merging this until we can confirm what needs to be done!

ascott1 commented 9 years ago

I updated this to also fix the IE internal linking bug and include the refactoring suggestions made by @KimberlyMunoz and @cmc333333.

Now when a user clicks an internal link in IE the browser window scrolls to the correct position. I've verified this in IE10.

KimberlyMunoz commented 9 years ago

I tested this on IE 10 and IE 11 this morning and it fixes that strange routing bug :raised_hands:, but introduces a new bug when comparing differences that can lead to long urls like this, http://localhost:3000/diff/1005-6/2012-12121/2011-11111?from_version=2011-1111#1005-6/2012-12121/2011-11111?from_version=2011-11111.

ascott1 commented 9 years ago

http://img.pandawhale.com/91743-I-am-this-close-gif-T2-Termina-SkCg.gif

ascott1 commented 9 years ago

@KimberlyMunoz my last commit should fix this. Do you mind taking a peak and merging for me once you've tested?

KimberlyMunoz commented 9 years ago

Sure. Going to take a look now.

KimberlyMunoz commented 9 years ago

Great. I just checked this across multiple Internet Explorers and it looks to be working well.

ascott1 commented 9 years ago

:boom: :tada: :dancers: