Closed ascott1 closed 9 years ago
@KimberlyMunoz do you mind reviewing this when you get a chance?
Looks good.
Where is .loading-spinner
going to be used? There's a few cases where I create it and it spins a little too much by rotating in a huge circle instead of in place, like say... if you replaced the cf-icon-right icon with a loading spinner to fire it up really quick for a pull request. If it's only going to be used in one place and it works there, there probably isn't a reason to change it, but I found setting the height and width stops that issue from coming up.
.loading-spinner:after {
.cf-icon;
.cf-icon__spin;
display: block;
width: 1em;
height: 1em;
content: @cf-icon-update;
color: @pacific;
font-size: 1.375em;
margin: 2em auto;
}
Good suggestion. I added the height and width for future compatibility. It's going to be used on the fr-notices that are loaded on the landing page so that there's no longer a weird eye jolt as content just shows up there.
Cool. I'll merge when the Travis build finishes.
WHOOHOO :repeat: