search

cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

Add npm postinstall script #715

Closed ascott1 closed 9 years ago

ascott1 commented 9 years ago

Now running npm install will also run bower install and the default grunt task, to simplify the front-end build process.

This also rids us of the pesky .min.css file, which was apparently hanging around somewhere.

ascott1 commented 9 years ago

@KimberlyMunoz when you get a chance, can you review this and make sure it does what's advertised on the tin?

KimberlyMunoz commented 9 years ago

Yep. I'll get to this soon, especially if it means we're done with that .min.css file.

ascott1 commented 9 years ago

:fire: .min.css :fire:

KimberlyMunoz commented 9 years ago

The postinstall script works great and I think that's ready to go. But I'm getting an error with JSDOM when I run the unit tests since it looks like they dropped support for 4.x on node.js

`jsdom 4.x onward only works on io.js, not Node.js™: https://github.com/tmpvar

Changing L30 of package.json to "jsdom": "^3.1.2", fixes it.

ascott1 commented 9 years ago

That is frustrating. I'll make that change and push.

KimberlyMunoz commented 9 years ago

Looks good! Merging 🌻

ascott1 commented 9 years ago

Thanks! :zap: