Refactor drawer state - Githubissues

cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information

Other

28 stars 43 forks source link

Refactor drawer state #720

Closed ascott1 closed 9 years ago

ascott1 commented 9 years ago

This refactor's the drawer state in the following ways:

No longer relies on the confusing and generic active class
Keeps the drawer state out of the DOM
Drawer remains open or closed when resizing the browser window (a :gift: for @khandelwal)
Removes redundant small screen specific css
Removes the janky animation

@KimberlyMunoz can you review and test?

KimberlyMunoz commented 9 years ago

:+1:

While I was keyboard testing the last pull request, I noticed that there was a bug while navigating between search/timeline/toc and the refactoring here unintentionally fixed it! :clap:

KimberlyMunoz commented 9 years ago

Although sadly, this doesn't fix the outstanding bug on Android ICS using the stock browser.

ascott1 commented 9 years ago

Although sadly, this doesn't fix the outstanding bug on Android ICS using the stock browser.

Argh, I was really hoping it would fix that. Silly position: fixed

KimberlyMunoz commented 9 years ago

Yeah. I merged anyway since it was an existing issue.