search

cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

Add frontendbuild.sh script #724

Closed ascott1 closed 9 years ago

ascott1 commented 9 years ago

The main purpose of this pull request is to add the frontendbuild.sh script, which will make a copy of the config file, run npm install, run bower install, and run a full set of grunt tasks.

It also contains a little bit of cleanup of the package.json and stops inlining modernizr when developing locally.

Review

@KimberlyMunoz

ascott1 commented 9 years ago

Also, I'd like @imuchnik to take a look at this.

ascott1 commented 9 years ago

It's worth noting that the package.json postinstall script duplicates some of the functionality of the frontendbuild.sh file. If this gets the thumbs up, should we suggest that users of the repo run frontendbuild.sh in the REAMDE in place of npm install and remove the postinstall script altogether?

ascott1 commented 9 years ago

Last comment in my conversation with myself...

Is it possible to run this along with buildout? It would further simplify the initial application setup.

cmc333333 commented 9 years ago

This is great, @ascott1 ! I think we should take a step back at some point and look at the three repos holistically to try to figure out a quick start path. The VM route is a good start; I wonder if it's not the double-down solution. Perhaps we should have the VM instructions in https://github.com/cfpb/eregulations and reference them in each of the repositories. The individual repos would just describe "custom" setup?

ascott1 commented 9 years ago

Perhaps we should have the VM instructions in https://github.com/cfpb/eregulations and reference them in each of the repositories. The individual repos would just describe "custom" setup?

That's what I've been envisioning as a sort of "ideal" state. I think it makes a lot of sense.

imuchnik commented 9 years ago

:+1: