search

cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

Add the dash layer formatting and associated templates and style #727

Closed willbarton closed 9 years ago

willbarton commented 9 years ago

This PR handles the JSON created in cfpb/regulations-parser#276 for elements in the regulation XML like this:

<FP SOURCE="FP-DASH">Developer's Name</FP>

In the regulation XML. These are "paragraphs that fill with dashes" and are used in regulations for model forms.

This adds code to handle the FP-DASH paragraphs in in the formatting layer, as well as a template for rendering them and styles to create the "dash" (in this case, an underline) that extends after the text to the end of the line.

The result appears like this:

image

This PR goes along with cfpb/regulations-parser#276.

@ascott1 @grapesmoker

cmc333333 commented 9 years ago

More good stuff. Also, I'm so sorry for buildout.

willbarton commented 9 years ago

I'm so sorry for buildout.

I too have created projects that use buildout.

ascott1 commented 9 years ago

Any idea why Travis has suddenly decided to error on buildout? Is it something we should ignore or can it be fixed?

willbarton commented 9 years ago

We should probably fix it — there's a problem with one of the buildout components (djangorecipe, which installs Django). It's been updated, by the looks of it, and we're using a deprecated option.

Error: The projectegg option is deprecated. See the changelog for 2.0 at http://pypi.python.org/pypi/djangorecipe/2.0

I can make a separate PR to fix that. Until then, regulations-site probably won't build for anyone who hasn't already got it built-out.

ascott1 commented 9 years ago

Travis is going to keep failing when setting up the dummy-api, but let's merge this. Everything is ok in here.