Begin Less refactor - Githubissues

cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information

Other

28 stars 43 forks source link

Begin Less refactor #730

Closed ascott1 closed 9 years ago

ascott1 commented 9 years ago

This does a few things:

Switches to using grunt-contrib-cssmin for minifying css, which resulted in 20kb+ of savings
Removes all of the weird media query specific files so that media queries are easier to track down
Refactors the layout.less in the direction of things being mobile first
Review

@KimberlyMunoz

ascott1 commented 9 years ago

@KimberlyMunoz I moved a lot around here. Would you mind giving this a thorough look through when you get a chance? I'm hoping this makes the layout easier to grok, but please feel free to make recommendations.

Also, the Travis build is likely to fail because of a dependency issue in regulations-core, but the actual tests should pass.

KimberlyMunoz commented 9 years ago

Looking at this today!

ascott1 commented 9 years ago

Thanks!

KimberlyMunoz commented 9 years ago

:+1:

Big fan of the work done on layout.less

giphy

ascott1 commented 9 years ago

Big fan of the work done on layout.less

Shucks, thank you. Hopefully it'll be a teeny bit easier to figure out what's going on in that file now.

cfpb / regulations-site

Begin Less refactor #730

Review