search

cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

Add loading indicator for Section by Section analysis, closes #725 #733

Closed ascott1 closed 9 years ago

ascott1 commented 9 years ago

722 changed the way the SxS breakaway view is loaded to animate before the content is loaded. That means that when content is loaded slowly, the user stares at a semi-blank screen while waiting for the request to finish. This adds a little spinning indicator in those scenarios.

spinning

It's not beautiful, but it's rare that this appears and is a definite UX win.

Review

@KimberlyMunoz do you mind doing the honors?

willbarton commented 9 years ago

I keep watching the gif waiting for something to load.

(I think that means it works as intended.)

KimberlyMunoz commented 9 years ago

I'm getting an error compiling the LESS since mixins.less is called before cf-icons.less. Changing the order in main.less should fix it.

ascott1 commented 9 years ago

I'm getting an error compiling the LESS since mixins.less is called before cf-icons.less. Changing the order in main.less should fix it.

Oh, whoops! Thanks for catching this. Not sure why I didn't get the error locally.

ascott1 commented 9 years ago

Updated and pushed