Closed ascott1 closed 9 years ago
All of the button code was part of an internal template. That commit has been reverted. This can be merged once it's reviewed @willbarton
So, the spacing to the left of "Subpart A" in the first screenshot not matching the space to the right of "Effective Date" bugs me, visually. Should it have the same right alignment over the body content?
So, the spacing to the left of "Subpart A" in the first screenshot not matching the space to the right of "Effective Date" bugs me, visually. Should it have the same right alignment over the body content?
I agree that it probably should. That's how it was mocked up, but let me follow up on it
Another comment, the bullet points on landing pages line up to the left of the header. In an of itself, I don't have a problem with that... but it's visually jarring because the ordered lists we use for regulation text have their markers line up directly under their heading.
Oh, hmm. Looking at the design manual, the bullets align with the text. Going to make that change. Good catch @willbarton!
@willbarton these should be fixed. Thanks for being a developer/typographical-wizard now that "eagle eyes" @jehlers is no longer with us.
Effective date aligns with the interpreation box:
Bullets are correctly indented:
:+1: This looks good to me.
@KimberlyMunoz Do you want to take a pass at it before it's merged?
I can do that. I just got caught up with all my email and stuff. :)
:+1:
This makes several improvements as suggested by our UX team.
Changes
Review
Screenshots