cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

UX improvements #742

Closed ascott1 closed 9 years ago

ascott1 commented 9 years ago

This makes several improvements as suggested by our UX team.

Changes

screen shot 2015-08-13 at 12 09 08 pm screen shot 2015-08-13 at 12 09 46 pm
ascott1 commented 9 years ago

All of the button code was part of an internal template. That commit has been reverted. This can be merged once it's reviewed @willbarton

screen shot 2015-08-14 at 11 25 11 am

willbarton commented 9 years ago

So, the spacing to the left of "Subpart A" in the first screenshot not matching the space to the right of "Effective Date" bugs me, visually. Should it have the same right alignment over the body content?

ascott1 commented 9 years ago

So, the spacing to the left of "Subpart A" in the first screenshot not matching the space to the right of "Effective Date" bugs me, visually. Should it have the same right alignment over the body content?

I agree that it probably should. That's how it was mocked up, but let me follow up on it

willbarton commented 9 years ago

Another comment, the bullet points on landing pages line up to the left of the header. In an of itself, I don't have a problem with that... but it's visually jarring because the ordered lists we use for regulation text have their markers line up directly under their heading.

screen shot 2015-08-17 at 12 52 04 pm screen shot 2015-08-17 at 12 51 46 pm

ascott1 commented 9 years ago

Oh, hmm. Looking at the design manual, the bullets align with the text. Going to make that change. Good catch @willbarton!

ascott1 commented 9 years ago

@willbarton these should be fixed. Thanks for being a developer/typographical-wizard now that "eagle eyes" @jehlers is no longer with us.

Effective date aligns with the interpreation box:

screen shot 2015-08-18 at 10 23 46 am

Bullets are correctly indented:

screen shot 2015-08-18 at 10 24 21 am

willbarton commented 9 years ago

:+1: This looks good to me.

@KimberlyMunoz Do you want to take a pass at it before it's merged?

KimberlyMunoz commented 9 years ago

I can do that. I just got caught up with all my email and stuff. :)

KimberlyMunoz commented 9 years ago

:+1: