search

cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

Set up view tests #753

Closed ascott1 closed 8 years ago

ascott1 commented 8 years ago

Up until now we haven't been testing JS views, because it is a tricky thing to do. Unfortunately, a lot of the current application logic lives in those views. This sets up some basic view testing specifically for the sidebar views for now.

I'm hoping to work with @imuchnik when she returns from vacation to figure out how to mock the Ajax requests, which many of the views rely on.

This can remain unmerged until it is in a more complete state, but I wanted to open up a PR to more easily get more eyes on it.

imuchnik commented 8 years ago

@ascott1 I would live to pair on this. Please schedule some time, any time.

ascott1 commented 8 years ago

I think this can and should be merged in. I'll continue to add additional tests over the coming week(s), but merging this now would make for smaller and more reviewable pull requests in the future.

What do you think @imuchnik?

imuchnik commented 8 years ago

Yes. Agreed.