search

cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

Hide wayfinding sub paragraphs in 1004.2 #756

Closed ascott1 closed 8 years ago

ascott1 commented 8 years ago

This splits up the sub paragraphs in the wayfinding and hides them in section 1004.2. We also have the ability to easily add this feature to other sections if/when needed.

Screenshots

screen shot 2015-11-19 at 3 39 20 pm

screen shot 2015-11-19 at 3 39 28 pm

Review

@willbarton or @grapesmoker

willbarton commented 8 years ago

:+1:

cmc333333 commented 8 years ago

We took this approach, effectively teaching the JS about paragraphs which don't have markers: https://github.com/18F/regulations-site/pull/20/

Related - the search templates probably also need to be aware: https://github.com/18F/regulations-site/pull/18

willbarton commented 8 years ago

@cmc333333 I feel like both approaches are stop-gaps to a certain degree. With the https://github.com/cfpb/regulations-schema we'll be able to be explicitly specify markers, and then we can take that into account on the front-end. We've also had some discussion about what should actually be shown for markerless paragraphs... and that's something we want to explore a bit more with our SMEs and non-existent UXers.

cmc333333 commented 8 years ago

@willbarton maybe a transition plan would be to pass that information through to the template the way we'd expect it to come from the schema? Then the frontend can start solving the general problem independently of when the schema is finished.