cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

Remove Bower dependency #770

Closed ascott1 closed 8 years ago

ascott1 commented 8 years ago

This moves us to completely using npm to manage packages on the front-end.

To test:

  1. Clone my branch locally and run the frontendbuild.sh script. This will run npm install and the grunt build command. The site should build with no errors.
  2. Start the server and ensure that there are no console.log errors reporting unfound scripts.

    Review

@willbarton

willbarton commented 8 years ago

giphy-5

willbarton commented 8 years ago

Did you mean to commit regulations/static/regulations/js/built/lib/respond/respond.min.js?

cmc333333 commented 8 years ago

Ugh. We should have sent this up: https://github.com/18F/regulations-site/pull/62

Highlights relevant for you:

ascott1 commented 8 years ago

Ugh. We should have sent this up: 18F#62

Double ugh.

Did you mean to commit regulations/static/regulations/js/built/lib/respond/respond.min.js?

@willbarton nope. fix coming.

ascott1 commented 8 years ago

This should be all set, unless @cmc333333 would rather PR the 18F changes (which I'm also ok with)

willbarton commented 8 years ago

stimpy-red-button