cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

Fetch SxS by version or notice_id #781

Closed willbarton closed 8 years ago

willbarton commented 8 years ago

This PR fixes an issue where SxS fetching by version would fail with older data that’s only associated with notice_ids (without the version date extension).

This should work now with both old eCFR parser-generated JSON as well as RegML parser-generated JSON.

@grapesmoker @hillaryj @ascott1

ascott1 commented 8 years ago

This is working for me locally. Thanks @willbarton!

@grapesmoker or @hillaryj can you review the Python and give it a :+1:?

willbarton commented 8 years ago

I should note, best tested with Reg E, although I've had some issues with B too.