cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

use cfgov_setup for building frontend assets #817

Closed rosskarchner closed 7 years ago

rosskarchner commented 7 years ago

This actually fails right now for unrelated reasons

Done, without errors.
✗ High severity vulnerability found on minimatch@0.2.14
- desc: Regular Expression Denial of Service
- info: https://snyk.io/vuln/npm:minimatch:20160620
- from: regulations-site@0.1.0 > chokidar@0.12.6 > readdirp@1.3.0 > minimatch@0.2.14
Upgrade direct dependency chokidar@0.12.6 to chokidar@1.1.0 (triggers upgrades to readdirp@2.0.1 > minimatch@3.0.2)

Tested 32 dependencies for known vulnerabilities, found 1 vulnerability, 1 vulnerable path.
rosskarchner commented 7 years ago

It's also worth celebrating that the old code probably wouldn't have caught this error, or at least failed later, because call doesn't care whether the command succeeds or fails:

https://github.com/cfpb/regulations-site/pull/817/files#diff-2eeaed663bd0d25b7e608891384b7298L23

willbarton commented 7 years ago

@rosskarchner Hmm, the failure in Travis looks different from that, it seems to be with fsevents.

rosskarchner commented 7 years ago

Either way, it cuts to the problem that started this whole thing: making sure the python build fails if the frontend build fails ;)

willbarton commented 7 years ago

@rosskarchner Looks like this should be fixed!

rosskarchner commented 7 years ago

Trying it now

rosskarchner commented 7 years ago

looks good!