search

cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

Use nvm explicitly to enforce npm version #847

Closed chosak closed 6 years ago

chosak commented 6 years ago

This change modifies how the Node version is specified in the Travis CI build. The "nodejs: 6" entry in .travis.yml wasn't properly setting the Node version to the desired 6.x version. This was causing problems because Travis was using Node 8.x, which modified the npm-shrinkwrap.json file. This in turn created a "dirty" git state which caused release wheels to be named improperly.

Ping @higs4281 who I know was experiencing something similar in another repository.

This repository should probably be upgraded to explicitly use Node 8 instead of Node 6, but that is left for a future effort.

higs4281 commented 6 years ago

experiencing something similar

Turned out to be a local issue.

chosak commented 6 years ago

@anselmbradford yes, thanks!