cfpb / regulations-site

(DEPRECATED) Web interface for viewing U.S. federal regulations and other regulatory information
Other
28 stars 43 forks source link

Accessibility improvements #851

Open contolini opened 6 years ago

contolini commented 6 years ago

A couple small accessibility errors surfaced when running eregs through https://validator.w3.org.

Additions

Changes

Removals

Testing

anselmbradford commented 6 years ago

This looks good to me, but I don't have the site installed either so can't double-triple-verify the dfn-key-term change.

KimberlyMunoz commented 6 years ago

👋 (I miss you all)

So adding aria-label to that link is going to make this link

<a href="http://consumerfinance.gov/" class="external" aria-label="Link opens in a new window" target="_blank">Consumer Financial Protection Bureau</a>

Read "Link, Link opens in a new window" instead of "Link, Consumer Financial Protection Bureau"

It might be better to add a <span class="visually-hidden"> with the that supplemental text (with the right Capital Framework class) or use title instead as suggested in this really old Deque post on the topic.

anselmbradford commented 6 years ago

😱 👋 Hi Kim!!