Open contolini opened 6 years ago
This looks good to me, but I don't have the site installed either so can't double-triple-verify the dfn-key-term
change.
👋 (I miss you all)
So adding aria-label
to that link is going to make this link
<a href="http://consumerfinance.gov/" class="external" aria-label="Link opens in a new window" target="_blank">Consumer Financial Protection Bureau</a>
Read "Link, Link opens in a new window" instead of "Link, Consumer Financial Protection Bureau"
It might be better to add a <span class="visually-hidden">
with the that supplemental text (with the right Capital Framework class) or use title instead as suggested in this really old Deque post on the topic.
😱 👋 Hi Kim!!
A couple small accessibility errors surfaced when running eregs through https://validator.w3.org.
Additions
alt
attribute to the supplement sample imageChanges
ria-label
->aria-label
Removals
dfn-key-term
isn't a valid HTML attribute and as far as I can tell isn't being used anywhere in the codebase. I removed it.Testing