Closed meissadia closed 2 weeks ago
@natalia-fitzgerald I've updated this PR to switch blank
fields to display as "Not provided". The screenshot above reflects these changes.
@natalia-fitzgerald Added the warning alert when missing TIN or Type of FI. Screenshot above has been updated.
I notice the spacing between !
icon and the text in my implementation compared to your reference image differs (less in my implementation). Wondering if this is a one-off issue we should address in the SBL Frontend or if this is an issue with the DSR's Alert (field-level) component.
@natalia-fitzgerald Also updated to include the alert for Lapsed
LEIs.
@natalia-fitzgerald Alert message for Type of financial institution
has been updated. Screenshot updated.
Based on the referenced PR about Alert spacing, sounds like a "later" item, so I'll leave it alone for now.
Closes #1013
Completed Changes
Type of Financial Institution
,Federal Taxpayer Identification Number (TIN)
show as "Not provided" when missingLEI Status
from "Active/Inactive" to "Issued/Lapsed"Type of Financial Institution
,Federal Taxpayer Identification Number (TIN)
, orLEI Status
when missing/lapsed.How to test this PR
Language updates
[ViewInstitutionProfile > index.tsx] Replace the
data
param highlighted in the screenshot below with the following.Visit the Institution profile page
Confirm fields display the correct fallback value (blank or "Not applicable").
Screenshots
Language updates
Always populated
in the reference table are populated with their fieldname (i.e FI_INSTITUTION_NAME)