cfpb / sbl-frontend

Small Business Lending Filing Application
MIT License
2 stars 1 forks source link

[View Institution Profile] Language updates #1024

Closed meissadia closed 2 weeks ago

meissadia commented 1 month ago

Closes #1013

Completed Changes

How to test this PR

Language updates

    const testBlankValues = {
      lei: 'FI_LEI',
      name: 'FI_INSTITUTION_NAME',
      hq_address_street_1: 'HQ_ADDRESS_STREET_1',
      hq_address_city: 'HQ_ADDRESS_CITY',
      hq_address_state: 'HQ_ADDRESS_STATE',
      hq_address_state_code: 'HQ_ADDRESS_STATE_CODE',
      hq_address_zip: 'HQ_ADDRESS_ZIP',
    };
  1. [ViewInstitutionProfile > index.tsx] Replace the data param highlighted in the screenshot below with the following.

    Screenshot 2024-10-22 at 2 03 45 PM
  2. Visit the Institution profile page

  3. Confirm fields display the correct fallback value (blank or "Not applicable").

Screenshots

Language updates

screencapture-localhost-8899-institution-123456789TESTBANK123-2024-11-01-10_20_28

meissadia commented 3 weeks ago

@natalia-fitzgerald I've updated this PR to switch blank fields to display as "Not provided". The screenshot above reflects these changes.

meissadia commented 3 weeks ago

@natalia-fitzgerald Added the warning alert when missing TIN or Type of FI. Screenshot above has been updated.

I notice the spacing between ! icon and the text in my implementation compared to your reference image differs (less in my implementation). Wondering if this is a one-off issue we should address in the SBL Frontend or if this is an issue with the DSR's Alert (field-level) component.

meissadia commented 3 weeks ago

@natalia-fitzgerald Also updated to include the alert for Lapsed LEIs.

meissadia commented 3 weeks ago

@natalia-fitzgerald Alert message for Type of financial institution has been updated. Screenshot updated.

Based on the referenced PR about Alert spacing, sounds like a "later" item, so I'll leave it alone for now.