Upgrade to Node v22 - Githubissues

meissadia commented 2 weeks ago

Close #1040

Changes

[e2e] Update tests for View Institution Profile that were missed as part of #1013
[fix] [View Institution Profile] Display alert when sbl_institution_types is null or []
Updated .nvmrc to use v22
Updated package.json -> engines to use Node v22
Update Github actions to use Node v22
Updated Dockerfile to use new node-js-alpine:3.20 base image

Pull branch
nvm use
yarn start to easily launch all backend services
yarn docker-build-and-run to run the container version of the Frontend
Update your .env file to run tests against the container version
```
SBL_PLAYWRIGHT_TEST_TARGET="http://localhost:8085"
```
yarn playwright test --workers 4
Verify all tests pass

meissadia commented 1 week ago

Hmm, we'll also want to update the Dockerfile as well.

We'll also want to update the node version in the image.

@billhimmelsbach

[x] Update package.json
[x] Update Dockerfile
- Changing this to anything other than node18 (node20, node21, node22) fails.
- I've searched for other examples of this type of transformation, searched for a list of valid values for this -t <VERSION> argument, but I'm not finding anything that helps clarify my confusion.
[x] Update image
- I'm guessing this would be in the source image this container is based on? So will try to find that once I regain access.

meissadia commented 1 week ago

@billhimmelsbach I still don't know what to do about the build of import-meta-env but things seem to be working as-is.

It looks like the latest version of Node supported by pkg is v18 and the source repo is archived as of the start of 2024 so no further updates. https://www.npmjs.com/package/pkg-fetch#binary-compatibility