cfpb / sbl-frontend

Small Business Lending Filing Application
MIT License
2 stars 1 forks source link

Institution Profile pages - Update alert text for missing TIN and LEI #1052

Closed meissadia closed 1 week ago

meissadia commented 2 weeks ago

Closes #1050

Changes

How to test this PR

  1. [ViewInstitutionProfile > index.tsx] Replace the data param highlighted in the screenshot below with the following.

    const testBlankValues = {
      lei: 'FI_LEI',
      name: 'FI_INSTITUTION_NAME',
      hq_address_street_1: 'HQ_ADDRESS_STREET_1',
      hq_address_city: 'HQ_ADDRESS_CITY',
      hq_address_state: 'HQ_ADDRESS_STATE',
      hq_address_state_code: 'HQ_ADDRESS_STATE_CODE',
      hq_address_zip: 'HQ_ADDRESS_ZIP',
    };
    Screenshot 2024-10-22 at 2 03 45 PM
  2. Visit the Institution profile page

Screenshots

View institution profile

InstitutionProfile-view

Update institution profile

InstitutionProfile-update

natalia-fitzgerald commented 1 week ago

@meissadia Let me know whether any of these changes will be handled separately from this PR and I can approve the PR with a note referencing these issues (I assume this would apply to the width of the field-level alert and maybe the external link icon).

Here's a list of changes:

Already discussed in our call:

Found in my review of the latest screenshots:

meissadia commented 1 week ago

@natalia-fitzgerald

Will be separate:

View - Language for intro to Parent info section

intro-parent-entity

Update - Intro to Types of FI

intro-fi-types
natalia-fitzgerald commented 1 week ago

@meissadia

I am reviewing on DevPub and would like to make some additional changes.

Both View and Update pages

View form

Screenshot 2024-11-18 at 5 52 56 PM

Update form

Screenshot 2024-11-18 at 5 52 48 PM
natalia-fitzgerald commented 6 days ago

@meissadia I have 3 more content updates and hopefully we'll be good.

View

Screenshot 2024-11-19 at 3 20 09 PM

Screenshot 2024-11-19 at 3 20 15 PM

Update

Screenshot 2024-11-19 at 3 20 25 PM