cfpb / sbl-frontend

Small Business Lending Filing Application
MIT License
2 stars 1 forks source link

feat: [View/Update institution profile] Create a shared page-level alert for when API is unreachable #1056

Closed meissadia closed 1 week ago

meissadia commented 1 week ago

Closes #1054

Changes

How to test this PR

  1. Visit View institution profile
  2. Use Chrome devtools to block Institution API requests Screenshot 2024-11-13 at 10 51 26 AM
  3. Reload page
  4. Verify page-level alert and no crashes
  5. Visit Update institution profile
  6. Verify page-level alert and no crashes

Screenshots

View institution profile (api down)

view-down

Update institution profile (api down)

update-down

Update institution profile: LEI alert and Email domain(s) language

update-missing-lei

meissadia commented 1 week ago

Verify: Underline links in page-level alerts

natalia-fitzgerald commented 1 week ago

@meissadia The alert looks good. The intro text is not updated but I assume that once the other PR gets merged I will see those changes? If so I can approve this PR.

Is this screenshot misplaced?

Screenshot 2024-11-14 at 6 53 16 PM