cfpb / sbl-frontend

Small Business Lending Filing Application
MIT License
0 stars 1 forks source link

[Point of Contact] State Selector - Error/Hover/Focus styling updates #561

Open shindigira opened 3 months ago

shindigira commented 3 months ago

Changes needed

In this screenshot: First element is a regular input -- red borders -- but hover is overriding the red borders Second element is a select input -- red borders -- but hover is partially covering the red borders and with a different blue color

Screenshot 2024-05-21 at 11 39 51 PM
natalia-fitzgerald commented 3 months ago

@shindigira I made a ticket for making hover and focus more consistent across inputs. If we were to use the default hover and focus styling (Pacific blue) for the select and only used the status color when enabled (not for hover and focus) would this simplify the implementation? https://github.com/cfpb/design-system-react/issues/357

The select in the DSR and here should not include the "--select an option--" text by default. Helper text should be placed under the label and outside of the input field.

natalia-fitzgerald commented 3 months ago

@shindigira This is a related ticket. https://github.com/cfpb/design-system-react/issues/357

In the meantime, if you'd like to move forward (locally) with the styling for the input and select, here's the styling:

Ultimately I'd like to make the more comprehensive change at the DS level but I know we're up against beta launch so perhaps handling locally is the only option.

natalia-fitzgerald commented 3 months ago

@shindigira I reviewed this on AWS and I'm still seeing the red show through on hover and focus.

Screenshot 2024-06-03 at 10 39 43 PM
natalia-fitzgerald commented 3 months ago

@shindigira The error state styling should look like this:

Screenshot 2024-06-08 at 12 22 54 AM