Open natalia-fitzgerald opened 4 months ago
Text block should be 670px wide (currently set to 708px on the platform).
Ensure that this is true.
@billhimmelsbach In order to start to centralize the remaining open items I am moving this from this other ticket to here:
Text block should be 670px wide (currently set to 708px on the platform).
Ensure that this is true.
This is still not correct.
@tanner-ricks The pipe character spacing change (two spaces before and after) should be applied to all instances. I went through and checked and I think we are good on all but one that still needs to be fixed. Platform home still needs the correct spacing.
Platform home
View your user profile
Filing home
Filing flow header space
User interface updates
Issues ready to be worked on
For the following issues, create an issue for them and add this comment to the description "Relates to: https://github.com/cfpb/sbl-project/issues/286", and then link the PR to the item when it's completed
@tanner-ricks Pipe character between Financial institution name and Year should have two spaces before and after (check DSR)@tanner-ricks see note here: https://github.com/cfpb/sbl-frontend/issues/800#issuecomment-2498646527@billhimmelsbach Change all external links to open in a new tab (including links to cf.gov - outside of the platform) - Bill will put up Meissa's work on DevIssues that need to be confirmed were done:
For the following check the site to see if these are implemented, if they are, check the box and add your name
Issues that may take longer:
These issues might take longer than an hour or two, but feel free to pick them up if time allows
Below is the full list of issues, not categorized
1. Step indicator
[Story] https://github.com/cfpb/sbl-project/issues/277
Current implementation
Proposed implementation
2. Loading indicator
3. 500 and 404 errors
500 page: We have encountered an error. Visit the small business lending data submission platform homepage for additional resources or contact our support staff. Button: Visit homepage
404 page: Visit the small business lending data submission platform homepage for additional resources or contact our support staff. Button: Visit homepage
4. Enable save and continue (or submit) button
Upload file (mock-ups)
For discussion
PR for the following 4 scenarios
Scenarios for clicking "Save and continue"
Scenario 1: When no file has been uploaded and the user clicks "Save and continue", then they see "You must successfully upload your file and complete validation checks to save and continue."
Scenario 2: When a file is in the process of being uploaded and having validation checks performed and they click "Save and continue", then they will see "You must successfully upload your file and complete validation checks to save and continue."
Scenario 3: When a file fails to upload or get through validations, then the users sees a "Problem uploading your file" message. If a user clicks “Save and continue” when the page is in this state the alert is added to the bottom of the page (and the rest of the page content persists)
Scenario 4: When a file has been uploaded and validated (success) and the user clicks "Save and continue", they go to the errors pages.
Type of financial institution and Point of contact (mock-ups)
These will follow the standard forms flow where the alert appears at the top of the page with links to the relevant required fields. Clicking submit bounces the user to the top of the page where the form-level alert sits with the relevant jump links.
Resolve errors (mock-ups)
Review warnings (mock-ups)
5. Other updates/fixes
[x] Change all external links to open in a new tab (including links to cf.gov - outside of the platform)
[ ] @shindigira Bug: Multi-select state styling: Invalid blue line / red line on top of each other
[ ] @shindigira DSR component bug: Mobile pagination implementation doesn't match CFPB Design System component -- I spoke to Sigmund and he said he'd like to look into rebuilding the pagination component to use flexbox and maybe tweak the sizes of certain items. Here's an image of DS versus DSR
Shared platform home (authenticated)
View your user profile
Filing home
Upload file
Resolve errors
Review warnings
Provide point of contact
Post-MVP backlog items
Feedback from bug bashes (post-MVP testing)
Possible Design System component enhancements and updates
Discussion points for future discussion: