cfpb / sbl-project

Project management repo for the SBL project
Creative Commons Zero v1.0 Universal
1 stars 1 forks source link

[Epic] View or update your financial institution profile #11

Open kristenshaw4 opened 1 year ago

kristenshaw4 commented 1 year ago

Overview

Resources

Pages

Tasks

User stories

MVP (release date: 12/31/2024)

Open beta (released 8/1/2024)

Backlog

Technical requirements

Content requirements

Financial Institution data to show on this page (in this order):

User testing

Research Goals

Task Ideation

Current designs (MVP)

Updated: 2/16/2024

View View (LEI inactive)
Group 571 Group 572
Update Successful submission
Group 575 Group 574
natalia-fitzgerald commented 1 year ago

Notes from meeting on 8/18/2023

Here are the notes that @kristenshaw4 and I took during Friday's meeting with @Kibrael. Please feel free to edit to make these notes more accurate and useful.

Fields to include in R1 design

Please confirm that this list reflects the fields that should be included in the mock-up.

kristenshaw4 commented 1 year ago

Financial Institution data to show on this page (in this order):

Type of financial institution:

A financial institution can select one or more of the following:

Decisions discussed:

Outstanding questions:

none

User stories

billhimmelsbach commented 1 year ago

Heyo! Everything here looks good @kristenshaw4 and @natalia-fitzgerald, just one little change maybe in the user stories. I think we maybe need to cross out the last user story too after our discussions:

As a filer, I would like to be alerted when I need to provide additional information related to SBL filing (ex. missing Parent RSSD ID)

I think we settled on that we usually don't know what information they're missing based on the data we have, so we were going to avoid issuing alerts to the user?

kristenshaw4 commented 1 year ago

@billhimmelsbach "Alerted" is probably the wrong word... I think we do want to visualize for them on this page that a field is missing what might be required information for them. Would that be a more accurate statement?

billhimmelsbach commented 1 year ago

This is a @Kibrael domain probably, but as I understand it @kristenshaw4, we won't know if most of these fields are required for the institution to include? I think "Parent RSSD ID" is particularly a weird one, since they are required to give it to us if they have one, but some won't since it's something that's assigned to them by the Federal Reserve Board based on their institution type. So it's possible a Parent wouldn't have an RSSD ID, as I understand?

Maybe something to chat about during the backlog meeting? It's a little sad to me that we can't do more frontend validation, but what's "required" seems pretty tricky.

meissadia commented 1 year ago

@billhimmelsbach I've done a review of these pages to try to identify any Design System React (DSR) components that are not yet implemented. The only one I've seen so far is TextIntroduction.

Are there any components you've identified as "missing" from the DSR that I can prioritize for development? Anything you've had to implement in your dev branch that needs to be ported over to the DSR?

Components I see ( √ = already in DSR)

Verified

Draft

billhimmelsbach commented 1 year ago

Thanks @meissadia for doing an inventory of them!

How do you want to handle the minor style differences between components in the DSR versus the final designs that are in Figma? Looking at the simplified table for instance:

DSR Figma
Screenshot 2023-10-04 at 7 11 54 AM Screenshot 2023-10-04 at 7 12 18 AM

So for example when I make the SimplifiedTable's top header row without a gray background color for the institution page, should it just be a one-off styling difference from the DSR's default style?

Maybe after this issue is completed, we can briefly chat about deciding between maybe rolling some of these similarly minor style changes into the DSR, adding a style prop for major ones, or just leaving them one-off changes?

natalia-fitzgerald commented 1 year ago

@billhimmelsbach I think we should talk through inconsistencies as they come up. Sometimes there may be DS variations that haven't been captured in the DSR. Or the Figma file could be a slight deviation from the component. Generally we'll want to default to a strict adherence to the CFPB Design System / CFPB Design System React (DSR) - unless there is a functional reason for deviating. For now let's discuss on a case by case basis as we work through building the page. The DSR is still a work in progress so we can't assume it's the source of truth yet.

There are a mix of components in the DSR. Some are "Verified" and some are "Draft". The table component has not yet been verified. I am adding the components that you will need for this page to the list I will prioritize for the verification review.

natalia-fitzgerald commented 9 months ago

@dan-padgett @angelcardoz I think it would be helpful for us to review the User stories and Technical requirements (blank right now) for this Epic. We should create a user story for the Salesforce form to be sure that we are capturing all of the details.

natalia-fitzgerald commented 9 months ago

Next steps

natalia-fitzgerald commented 7 months ago

@angelcardoz

Decision

Last week the team discussed the question of conditional logic for the "Update your financial institution profile" form. The team determined that the logic around when or what should be editable (for the identifying and affiliate sections) is too complicated for MVP.

For MVP:

Post-MVP:

We created a task to capture this work which will be picked up post-MVP: https://github.com/cfpb/sbl-frontend/issues/248

These notes were pulled from the design comments and will inform the post-MVP task:

@Kibrael @nongarak @billhimmelsbach