cfpb / sbl-project

Project management repo for the SBL project
Creative Commons Zero v1.0 Universal
0 stars 1 forks source link

FIG error E0841 isn't checkable due to E0840 #233

Open jcadam14 opened 1 week ago

jcadam14 commented 1 week ago

Because the check for E0840 uses an enum list of accepted values (see below), an empty field in the business_ownership_status would fail the syntax check. E0841 validates that business_ownership_status must contain at least one value, so since an empty value in this field is already caught by E0840, E0841 isn't a "reachable" check and should be removed.

Accepted values enum of E0840:

accepted_values=[
              "1",
              "2",
              "3",
              "955",
              "966",
              "988",
          ]