cfr34k / t-echo-lora-aprs

LoRa-APRS firmware for the Lilygo T-Echo
Other
21 stars 4 forks source link

Added rx_time_valid variable #16

Closed cveith closed 10 months ago

cveith commented 10 months ago

Added rx_time_valid information to rx'ed aprs packets. Updating rx_timestamp once time is valid

fixes #15

cfr34k commented 10 months ago

Hi, thanks for the PR :)

Now that I looked at it again, I would appreciate some changes to improve code quality and make the function more clear to future readers of the code:

As I already said in #15, the functional changes look good to me. I'll test them as soon as I have access to my second T-Echo.

cveith commented 10 months ago

Hi Thomas,

i've fixed the things you mentioned. i also put the unobvious timestamp into a separate const and put a documentation on it.

best regards Chris, DL5CV

cfr34k commented 10 months ago

Thanks for the quick update!

I have been lucky in the meantime and someone was nearby with an active LoRa tracker. Therefore I could test your changes even without my second device. Works fine so far :)