Closed cveith closed 10 months ago
Hi, thanks for the PR :)
Now that I looked at it again, I would appreciate some changes to improve code quality and make the function more clear to future readers of the code:
wall_clock_is_valid()
function you added. The comment should clarify what needs to happen to make this function return true. Please use the Doxygen format (see the other function prototypes in the same file for a template).rx_time_valid
parameter here. Looks like some spaces sneaked in there ;-) . Everything else is indented with tabs.As I already said in #15, the functional changes look good to me. I'll test them as soon as I have access to my second T-Echo.
Hi Thomas,
i've fixed the things you mentioned. i also put the unobvious timestamp into a separate const and put a documentation on it.
best regards Chris, DL5CV
Thanks for the quick update!
I have been lucky in the meantime and someone was nearby with an active LoRa tracker. Therefore I could test your changes even without my second device. Works fine so far :)
Added rx_time_valid information to rx'ed aprs packets. Updating rx_timestamp once time is valid
fixes #15