search

cfrg / draft-irtf-cfrg-cpace

Other
2 stars 4 forks source link

Inconsistency in sid output constant ("CPaceSidOutput" vs. "CPaceSidOut") #19

Closed kevinlewi closed 3 weeks ago

kevinlewi commented 3 weeks ago

Hi @BjoernMHaase, I noticed that there is an inconsistency in the test vector generation for the optional sid output fields, see the following:

https://github.com/cfrg/draft-irtf-cfrg-cpace/blob/80c6b8528fc03cd8542879361e7ec404339b3c14/poc/CPace_testvectors.sage#L121-L123

In the reference implementation, the constant "CPaceSidOutput" is used, whereas in the document, the constant "CPaceSidOut" is used

BjoernMHaase commented 3 weeks ago

Thank you for bringing this up. It was just in time as we are just about to upload a new revision with mainly editorial changes.

If you have any further feedback: We would appreciate any suggestion that helps readers.

   

Gesendet: Montag, 14. Oktober 2024 um 08:38 Uhr Von: "Kevin Lewi" @.> An: "cfrg/draft-irtf-cfrg-cpace" @.> Cc: "BjoernMHaase" @.>, "Mention" @.> Betreff: [cfrg/draft-irtf-cfrg-cpace] Inconsistency in sid output constant ("CPaceSidOutput" vs. "CPaceSidOut") (Issue #19)

 

Hi @BjoernMHaase, I noticed that there is an inconsistency in the test vector generation for the optional sid output fields, see the following:

https://github.com/cfrg/draft-irtf-cfrg-cpace/blob/80c6b8528fc03cd8542879361e7ec404339b3c14/poc/CPace_testvectors.sage#L121-L123

In the reference implementation, the constant "CPaceSidOutput" is used, whereas in the document, the constant "CPaceSidOut" is used

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

BjoernMHaase commented 3 weeks ago

Resolved.