search

cfrg / draft-irtf-cfrg-hash-to-curve

Hashing to Elliptic Curves
Other
79 stars 27 forks source link

suggested edits #272

Closed kwantam closed 4 years ago

kwantam commented 4 years ago

Here are my suggested edits for everything through the relwork section.

kwantam commented 4 years ago

FYI, this is now rebased.

kwantam commented 4 years ago

@chris-wood I made some more edits to address the protocol/application concern. In the process I ended up revising the 'random oracle encodings' definition, because it wasn't quite correct.

I ended up removing the SHOULD language from the definition, because it doesn't seem like a definitions section is the right place to state requirements, but I'm happy to put back those sentences if you'd prefer.

chris-wood commented 4 years ago

@kwantam shall we merge? :)

kwantam commented 4 years ago

Sounds good to me :)

chris-wood commented 4 years ago

I'm nearly done with my pass, too. I'll submit a PR for that when complete!