search

cfrg / draft-irtf-cfrg-hpke

Hybrid Public Key Encryption
Other
48 stars 29 forks source link

Apply final test vectors #208

Closed chris-wood closed 3 years ago

chris-wood commented 3 years ago

This change updates the test vectors using the new (decoupled) version string. This should be the last time the vectors change for this particular specification.

cc @martinthomson, @jedisct1, @dmcardle, @kjacobs-moz, @sftcd, @rozbb, @blipp, @fredericjacobs, @ttaubert, @armfazh, @franziskuskiefer

chris-wood commented 3 years ago

Are you certain these vectors use the HPKE-v1 tag

I thought I had generated them with the right tag. Stand by.

rozbb commented 3 years ago

Sorry, I made a silly mistake. All tests passing 😅

chris-wood commented 3 years ago

Hah, well, I re-generated and re-applied them anyway. @rozbb, please take another look.

rozbb commented 3 years ago

Yup, all passing (which, again, is everything that doesn't use P521 or X448). Sorry about that

chris-wood commented 3 years ago

Yup, all passing (which, again, is everything that doesn't use P521 or X448).

Great -- thanks!

Sorry about that

No worries. You still win 1st place for fastest-to-verify. :-)

martinthomson commented 3 years ago

I've confirmed those vectors that use mode 0 or 1, X25519, SHA-2, and AES-128-GCM or ChaCha20Poly1305 in NSS.