search

cfry / dde

Dexter Development Environment
Other
44 stars 25 forks source link

get_page_async() relies on NPM request, which is deprecated #92

Open casselldev opened 1 year ago

casselldev commented 1 year ago

It is eventually going to be problematic that DDE's get_page_async() function relies on the NPM request package, which was deprecated in 2020 (see here: https://www.npmjs.com/package/request)

Although it mostly still functions, it is worth replacing request with a newer package like fetch or axios to prevent a breaking change down the line.

cfry commented 1 year ago

fetch is defined in DDE4 both IDE and Job Engine.

cfry commented 1 year ago

Everything will break. Everything has a lifetime. fetch is available now in dde4. request will likely work for decades. Unix should have been retired in 1980. To the detriment of the world, it wasn't :-(

On Mon, Dec 5, 2022 at 6:44 PM casselldev @.***> wrote:

It is eventually going to be problematic that DDE's get_page_async() function relies on the NPM request package, which was deprecated in 2020 (see here: https://www.npmjs.com/package/request)

Although it mostly still functions, it is worth replacing request with a newer package like fetch or axios to prevent a breaking change down the line.

— Reply to this email directly, view it on GitHub https://github.com/cfry/dde/issues/92, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJBG7J4Z25AVK5RQEEKHCTWLZ46BANCNFSM6AAAAAASU3JXXY . You are receiving this because you are subscribed to this thread.Message ID: @.***>