cfs-energy / cfspopcon

POPCONs (Plasma OPerating CONtours)
https://cfspopcon.readthedocs.io/en/latest/
MIT License
22 stars 14 forks source link

Unit handling and round-trip .nc conversion fixes #13

Closed tbody-cfs closed 11 months ago

tbody-cfs commented 11 months ago

Closes #10

hassec commented 11 months ago

Before merging this I'd like to make sure we have a way to reproduce the error described in #10. I've tried locally without luck so far and added a test that would catch the in #10 described problem, see #14

tbody-cfs commented 11 months ago

Think I've figured out how to reproduce the error. To fix https://github.com/cfs-energy/cfspopcon/actions/runs/7038938605/job/19156931593?pr=7, I added netcdf4 to the poetry environment. Then I can reproduce #10 with

poetry add netcdf4
rm -rf .venv
poetry install
poetry run python tests/regression_results/generate_regression_results.py
poetry run pytest
tbody-cfs commented 11 months ago

I broke it https://github.com/cfs-energy/cfspopcon/actions/runs/7039353397/job/19158160776?pr=13 🥳

tbody-cfs commented 11 months ago

And then I fixed it again https://github.com/cfs-energy/cfspopcon/actions/runs/7039432837/job/19158407447?pr=13 🥳🥳🥳