cfs-energy / cfspopcon

POPCONs (Plasma OPerating CONtours)
https://cfspopcon.readthedocs.io/en/latest/
MIT License
22 stars 14 forks source link

Read input variables from gEQDSK file #33

Closed ThomasWangAPAM closed 3 weeks ago

ThomasWangAPAM commented 5 months ago

Input_file_handling.py is modified to include a feature that allows cfspopcon to load several input variables from any geqdsk file. A streamlined version of omfit_classes/OMFITeqdsk.py is added to cfspopcon/OMFIT, from which Input_file_handling.py imports the OMFITgeqdskclass. Most of the development is done by @ThomasWangAPAM and @aarooshgr under the supervision of @nelsonand .

tbody-cfs commented 5 months ago

Suggest to use https://github.com/freegs-plasma/FreeQDSK instead

hassec commented 4 months ago

@ThomasWangAPAM please take a look at the read_case function: https://github.com/cfs-energy/cfspopcon/blob/656c65e73ea035f45be788191b66c0fcbe7bcf76/cfspopcon/input_file_handling.py#L15-L17

This already allows for loading a case from a file and overriding certain parameters. Which is essentially what the eqdsk option would do.

I'd suggest keeping the reading quantities from an eqdsk separate from cfspopcon. And one can use the read_case functionality to overwrite values if one want to run from an eqdsk.

github-actions[bot] commented 1 month ago

This PR has not seen any activity in the past 60 days. It is now marked as stale and will be closed in 7 days if no further activity is registered.