search

cfs-energy / cfspopcon

POPCONs (Plasma OPerating CONtours)
https://cfspopcon.readthedocs.io/en/latest/
MIT License
22 stars 14 forks source link

Infra cleanup part2 (addition of mcrf_from_fixed_P_sol algorithm) #45

Closed aarooshgr closed 3 months ago

aarooshgr commented 4 months ago

Added mcrf_from_fixed_P_sol algorithm. This allows the user to set P_sol to a fixed value (called "P_sol_target") in their .yaml file ("input_constant_P_sol.yaml" in this example), and then calculate the minimum core radiated fraction from P_sol_target and P_in.

Attached below are the POPCONs from the old code and new code, both with and without the P_sol constraint. "Old code" refers to the code before this merge, while "new code" refers to the code as modified in infra_cleanup_part2.

new_code_no_P_sol_constraint.png: new_code_no_P_sol_constraint

new_code_with_P_sol_constraint.png new_code_with_P_sol_constraint

old_code_no_P_sol_constraint.png:

old_code_no_P_sol_constraint

old_code_with_P_sol_constraint.png

old_code_with_P_sol_constraint
nelsonand commented 4 months ago

@aarooshgr Thanks!!

Does this replace everything in https://github.com/cfs-energy/cfspopcon/pull/23?

Can you post pictures of the POPCON (1) before a change, (2) after the change, but with no PSOL constraint and (3) with a PSOL constraint here?

nelsonand commented 4 months ago

@tbody-cfs: @aarooshgr added a script here to enable constant PSOL modeling. Feel free to merge it into https://github.com/cfs-energy/cfspopcon/tree/infra_cleanup_part2 when ready!