search

cfs-energy / cfspopcon

POPCONs (Plasma OPerating CONtours)
https://cfspopcon.readthedocs.io/en/latest/
MIT License
22 stars 14 forks source link

Implementing new I-mode scaling laws #46

Closed aarooshgr closed 3 months ago

aarooshgr commented 4 months ago

I added the new scaling laws to energy_confinement_scalings.yaml @nelsonand

Here are POPCONs for each of the added scaling laws:

image image

aarooshgr commented 3 months ago

Oh, I thought S meant scale factor. Will fix that!

On Wed, May 15, 2024 at 6:54 PM Oak Nelson @.***> wrote:

@.**** commented on this pull request.

In cfspopcon/formulas/power_crossing_separatrix/threshold_power.py https://github.com/cfs-energy/cfspopcon/pull/46#discussion_r1602344015:

  • def _calc_AUG_LI_threshold(average_electron_density, magnetic_field_on_axis, scale):
  • return float(2 0.07 (average_electron_density / 10) * (magnetic_field_on_axis / 2.4) * 0.39) scale
  • def _calc_HubbardNF17_LI_threshold(average_electron_density, magnetic_field_on_axis, scale):
  • return float(0.162 (average_electron_density / 10) (magnetic_field_on_axis * 0.262)) scale

@aarooshgr https://github.com/aarooshgr as far as I can tell from the slides, these formulas are missing the surface area (S) parameter

— Reply to this email directly, view it on GitHub https://github.com/cfs-energy/cfspopcon/pull/46#pullrequestreview-2059175315, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4GUOLOQW4RTF5RM35CR5RDZCPRS7AVCNFSM6AAAAABHE6LSD2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJZGE3TKMZRGU . You are receiving this because you were mentioned.Message ID: @.***>