search

cfs-energy / cfspopcon

POPCONs (Plasma OPerating CONtours)
https://cfspopcon.readthedocs.io/en/latest/
MIT License
22 stars 14 forks source link

Update I-mode Scalings #56

Closed nelsonand closed 3 months ago

nelsonand commented 3 months ago

This reopens https://github.com/cfs-energy/cfspopcon/pull/46#event-12848216546, now merging into main.

The PR contains simple updates to the I-mode LI power threshold and taue scalings from Amanda Hubbard. Addresses standing issue https://github.com/cfs-energy-internal/internal-cfspopcon/issues/149.

nelsonand commented 3 months ago

@tbody-cfs I saw you closed https://github.com/cfs-energy/cfspopcon/pull/46#event-12848216546. I naively went and opened this, merging into main, but it seems many of the changes for cfs-energy:infra_cleanup_part2 got wrapped up in the switch.

What should we do for the simple I-mode updates? They are few enough that I'd be happy to just rebase them onto main first, but if you are moving things around concurrently and I should wait for a bit that would be good to know.