I mode power threshold updates

[nelsonand]

This reopens https://github.com/cfs-energy/cfspopcon/pull/46#event-12848216546 and closes https://github.com/cfs-energy/cfspopcon/pull/56, now merging just the new threshold formulas into main.

The PR contains simple updates to the I-mode LI power threshold and taue scalings from Amanda Hubbard. Addresses standing issue https://github.com/cfs-energy-internal/internal-cfspopcon/issues/149.

[nelsonand]

@tbody-cfs I think this is all that is needed for the P_LI threshold additions

[tbody-cfs]

Hi @nelsonand and @aarooshgr,

Thanks for the work!! I've made a small edit which lets us switch the confinement scaling using the input.yaml file. I'm showing the effect of changing the scaling with the ITER98y2 scaling, since we don't yet have a good scaling for I-mode energy confinement

[aarooshgr]

Hi Tom,

Sure, I could do that. I’m away from my computer at the moment so I can get to it this evening

On Wed, Jun 12, 2024 at 3:47 AM Tom Body @.***> wrote:

@.**** requested changes on this pull request.

Could you pull in 0b80d7d https://github.com/cfs-energy/cfspopcon/commit/0b80d7d4dc96c42248bf27bf6185103ca1473bb9 from the I_mode_updates branch?

— Reply to this email directly, view it on GitHub https://github.com/cfs-energy/cfspopcon/pull/58#pullrequestreview-2112224724, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4GUOLPIXXRI5NT2AZVKIYLZG74H7AVCNFSM6AAAAABIGSIYLOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJSGIZDINZSGQ . You are receiving this because you were mentioned.Message ID: @.***>

[aarooshgr]

So, I just remembered that I don't have the access to push a commit to main... @nelsonand would you be able to do this?

[nelsonand]

@tbody-cfs @aarooshgr Should be merged now! Thanks!

[tbody-cfs]

@nelsonand @aarooshgr could you add the following to docs/doc_sources/physics_glossary.rst

At the end is fine. Make sure to match the indentation of the existing file

  confinement_power_scaling
    A :class:`~cfspopcon.named_options.ConfinementPowerScaling` indicating which confinement mode power-threshold scaling to use.

[aarooshgr]

@nelsonand @aarooshgr could you add the following to docs/doc_sources/physics_glossary.rst

At the end is fine. Make sure to match the indentation of the existing file

  confinement_power_scaling
    A :class:`~cfspopcon.named_options.ConfinementPowerScaling` indicating which confinement mode power-threshold scaling to use.

Hi Tom, just pushed this change to the I_mode_updates branch of my fork. Please let me know if you need anything else

[nelsonand]

Thanks @tbody-cfs !