search

cfs-tools / cfs-basecamp

Provides a framework and tools for developing, downloading, and integrating core Flight System (cFS) applications into an operational system.
Other
25 stars 3 forks source link

Consolidate osk_c_fw's (now app_c_fw) string lookup utilities #16

Open dmccomas opened 1 year ago

dmccomas commented 1 year ago

osk_c_fw provides string look up utilities like command manager's Boolean string. These should be consolidated into a single location. A related enhancement is creating typedefs for common enumerations using the cFS typedef coding idiom. This idiom defines one enum typedef for the symbols/values and a second typedef with a size that can be used for commands and telemetry messages. This change is not needed when EDS is used but it would be nice to clean it up.

dmccomas commented 1 year ago

I looked into the string lookup utilities, and they are all defined within the app_c_fw service that makes sense, so no changes are needed.

The following enumerations could have accompanying size definitions. More analysis needs to be done to locate instances of these being used for commands and telemetry. Moving the definitions to EDS should also be analyzed. Note core_json.h is provided by Free RTOS.

fileutil.h: FileUtil_FileState_t pktutil.h: PktUtil_FilterType_t staterep.h: STATEREP_TlmMode_t core_json.h: JSONStatus_t, JSONTypes_t