cfs-tools / cfs-basecamp

Provides a framework and tools for developing, downloading, and integrating core Flight System (cFS) applications into an operational system.
Other
25 stars 3 forks source link

Developer->Add App crashes when integrating a library with an EDS spec #18

Closed dmccomas closed 1 year ago

dmccomas commented 1 year ago

"Developer->Add App" assumes if an EDS spec exists then it contains command entries. trying to add PL_SIM_LIB will reproduce the error. The code should check for null command and telemetry entries.

image

dmccomas commented 1 year ago

Fixing this uncovered a couple of issues with the JSON lib/app spec and EDS processing. The big one being the checks done to target.cmake and cfe_es_startup.scr to see whether the lib/app exists or not were very crude. They could fail if the app name is in the comments and is an lib/app name is a subset of another lib/app name. For example, PL_SIM app is a subset of PL_SIM_LIB.