cfsimplicity / spreadsheet-cfml

Standalone library for working with spreadsheets and CSV in CFML
MIT License
126 stars 35 forks source link

CI is crashing, can't find testbox #368

Closed zspitzer closed 3 months ago

zspitzer commented 3 months ago

@cfsimplicity a good GHA debugging trick is to to dump out the working dir as an artifact

https://github.com/lucee/lucee-testlab/blob/main/.github/workflows/spreadsheet-cfml.yml#L27

if: always() is also useful, if things are crashing, it means it always runs (not the case here)

cfsimplicity commented 3 months ago

Thanks, Zac. I managed to stop the "can't find testbox" error by removing "installPaths": { "testbox": "test/testbox" } from my box.json.

But it still doesn't work and am struggling to debug.

Will try your tips, thanks.

cfsimplicity commented 3 months ago

Apologies, I found a rookie error in my tests: used mixed case for a variable used in test file paths which should have been lower case. Fixed and now Lucee at least is passing.

ACF 2021 and 2023 still failing I'm pretty sure because the image package needs installing.

cfsimplicity commented 3 months ago

https://github.com/cfsimplicity/spreadsheet-cfml/commit/92b874dc8f795f467d6898ed5d62f7d757d59a46 https://github.com/cfsimplicity/spreadsheet-cfml/commit/ab54fe1d9d7fa4a2f1952070fdc2a0641bbecb86 https://github.com/cfsimplicity/spreadsheet-cfml/commit/3adaf500d37cab2dcda49f1b1acfa1e76f7e144b

cfsimplicity commented 3 months ago

CI succeeding again on all engines.

https://github.com/cfsimplicity/spreadsheet-cfml/actions/runs/9462945259