search

cfss-old / fa18_hw01

Repository for homework 01
0 stars 45 forks source link

Peer evals for hw01 #40

Open bensoltoff opened 5 years ago

bensoltoff commented 5 years ago

@uc-cfss/fa18 As I mentioned in-class, pick any two pull requests at random and provide feedback. Starting next week you should have your evals auto-assigned to you as I outlined in class. Also make sure to send me your GitHub username so I can add you to the course organization. If you do not do this, you will not be able to access homework 2.

bensoltoff commented 5 years ago

@uc-cfss/fa18 also once the instructional staff evaluates a pull request, we close it. So for this week, make sure to look at both open and closed pull requests when selecting two to evaluate.

brooklinr9 commented 5 years ago

Dear Ben,

I try to do peer evals for hw1 today but it shows no pull to be reviewed by me. Has the review closed already?

Thanks.

Ruixi

On Tue, Oct 9, 2018 at 10:51 AM Benjamin Soltoff notifications@github.com wrote:

@uc-cfss/fa18 https://github.com/orgs/uc-cfss/teams/fa18 also once the instructional staff evaluates a pull request, we close it. So for this week, make sure to look at both open and closed pull requests https://github.com/uc-cfss/hw01/pulls?utf8=%E2%9C%93&q=is%3Apr when selecting two to evaluate.

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/uc-cfss/hw01/issues/40#issuecomment-428246663, or mute the thread https://github.com/notifications/unsubscribe-auth/Apu_SbQgO3AYWG2L_mrzhfs_v9EeEYnvks5ujMXugaJpZM4XNobN .

bensoltoff commented 5 years ago

@brooklinr9 all the pull requests have been evaluated by the instructional staff and closed. If you look through the closed pull requests, you should be able to still leave a comment and provide a peer review.