cfss-old / fp-EmilyForden

fp-EmilyForden created by GitHub Classroom
0 stars 0 forks source link

Peer Eval #3

Open futureofmaya opened 7 years ago

futureofmaya commented 7 years ago

Evaluation of final project by Emily

Topic Excellent Satisfactory Needs Work
Coding style satisfactory
Coding strategy satisfactory
Presentation: graphs excellent!
Presentation: tables satisfactory
Achievement, creativity excellent!
Ease of access satisfactory

Note: My eval scheme here follows Dr. Soltoff's "most things are satisfactory unless they're not" model.

Remarks:

Hi Emily! Here is a running list of thoughts: -You were right! We were supposed to make a GitHub website. Carly and I totally failed to do this. SO sorry if I mislead you on that front. So I guess this was a thing we could have all done. -I wish we knew why the server kept reloading on the ShinyApp -I like how organized your repo is: there is a limited number of files and they each do something useful. Ours is a disaster and a half. -Like me, I think you like to load may libraries that may or may not be necessary. So best practices for both of us: fewer unnecessary libraries. -I think you also want to make sure that the geom_whatever is indented after the ggplot line, since maybe that will cause errors? I think? -The subject is super cool. I love the whole digital humanities thing, which I think basically means any digital-ish analysis of texts (i.e. not twitter). -I think the part that I'm missing is what we can actually conclude about Livy and Augustus. It seems hard to link a lot of it causally, especially since, as you mention, Augustus doesn't actually come up. Totally ok if the whole thing is inconclusive too (which seems to be the case); it's definitely a start, and a very cool one!