search

cfv-project / cfv

Command-line File Verify
GNU General Public License v2.0
58 stars 10 forks source link

Fix tests for Python 3.12: remove "imp", fixes #21, #44 #53

Closed sbraz closed 6 months ago

sbraz commented 6 months ago

Hi, This patch is required for tests to pass with Python 3.12, along with 5259bcbe3434c6974f7a65cc435dd0b4cfc3f864.

The "imp" module was removed in Python 3.12. The replacement functions were added in Python 3.5, see https://docs.python.org/3/library/importlib.html#importlib.util.spec_from_file_location https://docs.python.org/3/library/importlib.html#importlib.util.module_from_spec

lxp commented 6 months ago

Thanks for your pull request! I will have a look at it, after fixing the CI pipeline.

lxp commented 6 months ago

Your changes look good, although I have not tested it yet. The CI pipeline is fixed, but it is not used in your PR yet. Could you please rebase your changes?

sbraz commented 6 months ago

@lxp done, sorry about the mess, I got confused because of the unusual target branch name :D

lxp commented 6 months ago

Thank you!